fix(plugins): expand ${env:*} and ${userHome} placeholders in plugin mcpServers#404
Open
Gucc111 wants to merge 1 commit into
Open
fix(plugins): expand ${env:*} and ${userHome} placeholders in plugin mcpServers#404Gucc111 wants to merge 1 commit into
Gucc111 wants to merge 1 commit into
Conversation
…mcpServers
Plugin manifest mcpServers only expanded ~ in args, leaving ${env:*} and
${userHome} as literal strings in cwd, env, url, and headers fields.
Extract a shared expandMcpString helper and apply it uniformly to both
user config and plugin manifest MCP server declarations.
Closes OpenBMB#245
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expandMcpString/expandMcpConfig) intosrc/mcp/config/expandPlaceholders.ts${env:*},${userHome},~) to plugin manifestmcpServersfields:args,cwd,env,url, andheadersloadMcpServerConfig.tsto reuse the shared helper instead of local inline functionsTest plan
McpClienttests pass without regressionFixes #245
Made with Cursor